[PATCH] D55650: [clangd] Fix an assertion failure in background index.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Ah you are right, the Optional.. Thanks!



================
Comment at: clangd/index/Background.cpp:384
   Action->EndSourceFile();
+  if (Clang->hasDiagnostics() &&
+      Clang->getDiagnostics().hasUncompilableErrorOccurred()) {
----------------
Then don't need to keep these checks anymore in the endsourcefileaction of 
indexingaction right?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55650/new/

https://reviews.llvm.org/D55650



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits