kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: clangd/index/Background.cpp:384
Action->EndSourceFile();
+ if (Clang->hasDiagnostics() &&
+ Clang->getDiagnostics().hasUncompilableErrorOccurred()) {
----------------
hokein wrote:
> kadircet wrote:
> > Then don't need to keep these checks anymore in the endsourcefileaction of
> > indexingaction right?
> We need indeed. We have other clients (`clangd-indexer`, and our internal
> indexer) using the `IndexingAction` -- we don't want symbols from broken TUs
> because they causes many troublesomes.
Ah you are right.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55650/new/
https://reviews.llvm.org/D55650
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
