[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348229: [analyzer] MoveChecker: Improve warning and note messages. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54560/new/ https:/

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ added a comment. In D54560#1302051 , @MTC wrote: > > The "moved-from" terminology we adopt here still feels a bit weird to me, > > but i don't have a better suggestion, so i just removed the single-quotes > > so that to at least feel proud about what

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained here accidentally, for later use. + return OK; Szelethus wrote: > NoQ wrote: > > S

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ updated this revision to Diff 176504. NoQ marked 4 inline comments as done. NoQ added a comment. Address comments! In D54560#1304155 , @Charusso wrote: > In D54560#1301870 , @NoQ wrote: > > > Write down full me

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

dcoughlin added a comment. Looks good! Some suggested minor tweaks to diagnostic text inline. Comment at: test/Analysis/use-after-move.cpp:146 +A b = std::move(a); // expected-note {{Object 'a' is moved}} +b = a; // expected-warning {{Moved-from object is c

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained here accidentally, for later use. + return OK; NoQ wrote: > Szelethus wrote:

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

Charusso added a comment. In https://reviews.llvm.org/D54560#1301870, @NoQ wrote: > Write down full messages in tests. When the message was updated from `'x' is > moved'` to `Object 'x' is moved`, the tests were not updated because they > kept passing because the former is still a sub-string of

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

MTC added a comment. > The "moved-from" terminology we adopt here still feels a bit weird to me, but > i don't have a better suggestion, so i just removed the single-quotes so that > to at least feel proud about what we have. I am personally fine with this terminology, this checker corresponds

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained here accidentally, for later use. + return OK; Szelethus wrote: > Maybe move this

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ updated this revision to Diff 174477. NoQ added a comment. Write down full messages in tests. When the message was updated from `'x' is moved'` to `Object 'x' is moved`, the tests were not updated because they kept passing because the former is still a sub-string of the latter. https://rev

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Awesome! :D Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained her

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, baloghadamsoftware. The warning piece traditionally describes the bug itself, i.e., "//The b