Szelethus added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained here accidentally, for later use. + return OK; ---------------- NoQ wrote: > Szelethus wrote: > > Maybe move this in-class? > Mmm, what do you mean? `explain.*` sounds like it either returns a string, or writes a stream object, but the return type isn't `void` nor string, maybe it'd be worth to put this comment in-class. But yea, this is over the top nitpicking, I don't insist :) https://reviews.llvm.org/D54560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits