NoQ added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386
+ }
+ // Provide the caller with the classification of the object
+ // we've obtained here accidentally, for later use.
+ return OK;
----------------
Szelethus wrote:
> NoQ wrote:
> > Szelethus wrote:
> > > Maybe move this in-class?
> > Mmm, what do you mean?
> `explain.*` sounds like it either returns a string, or writes a stream
> object, but the return type isn't `void` nor string, maybe it'd be worth to
> put this comment in-class.
>
> But yea, this is over the top nitpicking, I don't insist :)
Fxd!
================
Comment at: test/Analysis/use-after-move.cpp:146
+ A b = std::move(a); // expected-note {{Object 'a' is moved}}
+ b = a; // expected-warning {{Moved-from object is copied
'a'}} expected-note {{Moved-from object is copied 'a'}}
}
----------------
dcoughlin wrote:
> "Moved-from object is copied 'a'" doesn't read quite right. I think the
> object name is in the wrong spot. Instead, I would suggest: "Moved-from
> object 'a' is copied"
Whoops!!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54560/new/
https://reviews.llvm.org/D54560
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
