This revision was automatically updated to reflect the committed changes.
Closed by commit rC341766: [OpenMP] Add support for nested 'declare
target' directives (authored by kli, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51378?vs=164037&id=164596#toc
Repository:
rC C
ABataev accepted this revision.
ABataev added a comment.
LG
https://reviews.llvm.org/D51378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
patricklyster updated this revision to Diff 164037.
patricklyster added a comment.
Previous implementation only supported immediately nested declare targets such
as below:
#pragma omp declare target
#pragma omp declare target
int foo();
#pragma omp end declare target
int bar(
RaviNarayanaswamy accepted this revision.
RaviNarayanaswamy added a comment.
Ok.
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D51378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
patricklyster added a comment.
In https://reviews.llvm.org/D51378#1219474, @RaviNarayanaswamy wrote:
> I did not see the code where check is done if Nestingdepth is 0 at end of
> compilation.
Sorry I should clarify. You will get an error if you have an unmatched `#pragma
omp declare target` o
RaviNarayanaswamy added a comment.
I did not see the code where check is done if Nestingdepth is 0 at end of
compilation.
Repository:
rC Clang
https://reviews.llvm.org/D51378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
patricklyster added a comment.
In https://reviews.llvm.org/D51378#1218184, @RaviNarayanaswamy wrote:
> We should just go with generating an error if the DeclareTargetNestingLevel
> is not 0 at the end of compilation unit.
> Hard to detect if user accidentally forgot to have end declare in hea
Hahnfeld added a comment.
In https://reviews.llvm.org/D51378#1218184, @RaviNarayanaswamy wrote:
> We should just go with generating an error if the DeclareTargetNestingLevel
> is not 0 at the end of compilation unit.
> Hard to detect if user accidentally forgot to have end declare in header
RaviNarayanaswamy added a comment.
We should just go with generating an error if the DeclareTargetNestingLevel is
not 0 at the end of compilation unit.
Hard to detect if user accidentally forgot to have end declare in header file
and had it in the include file or it was intentional.
Reposito
patricklyster added a comment.
In https://reviews.llvm.org/D51378#1216600, @RaviNarayanaswamy wrote:
> Is there a way to tell if the header files have matching omp declare
> target/omp end declare target.
> The reason is if one of the header files is missing a matching omp end
> declare targ
RaviNarayanaswamy added a comment.
Is there a way to tell if the header files have matching omp declare target/omp
end declare target.
The reason is if one of the header files is missing a matching omp end declare
target all files which include it will end up having everything marked with
dec
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D51378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
Herald added subscribers: cfe-commits, guansong.
Add the capability to nest multiple declare target directives - including
header files within a declare
13 matches
Mail list logo
