patricklyster added a comment.

In https://reviews.llvm.org/D51378#1216600, @RaviNarayanaswamy wrote:

> Is there a way to tell if the header files have matching omp declare 
> target/omp end declare target.  
>  The reason is if one of the header files is missing a matching omp end 
> declare target all files which include it will end up having everything 
> marked with declare target


Are you suggesting to throw a warning/error at the end of the header file 
should there be a hanging `omp declare target`? Wouldn't this still be the same 
issue with each file that includes it still getting the same warning/error?

There is a corner case when the header file is missing the `end declare target` 
and the file that includes it has an extra `end declare target`. In this case 
no error will be thrown and all code in between the directives will be 
associated with the declare target. However, I don't know if this is something 
worth checking for.


Repository:
  rC Clang

https://reviews.llvm.org/D51378



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to