This revision was automatically updated to reflect the committed changes.
Closed by commit rL340005: [clangd] Fetch documentation from the Index during
signature help (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
ilya-biryukov wrote:
> ioeric wrote:
> > hokei
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
ioeric wrote:
> hokein wrote:
> > ioeri
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
hokein wrote:
> ioeric wrote:
> > ilya-biryuko
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
ioeric wrote:
> ilya-biryukov wrote:
> > ioeri
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
ilya-biryukov wrote:
> ioeric wrote:
> > drive
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
ioeric wrote:
> drive by: I think this
hokein added inline comments.
Comment at: clangd/index/Index.h:65
public:
+ static llvm::Optional forDecl(const Decl &D);
+
ilya-biryukov wrote:
> hokein wrote:
> > We already have this similar function in clangd/AST.h.
> Thanks for pointing this out.
> It's so
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:742
+llvm::DenseMap FetchedDocs;
+if (Index) {
+ LookupRequest IndexRequest;
hokein wrote:
> nit: do we want to log anything here? It may be useful for debug.
Definitely useful.
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
drive by: I think this should be `vlog` or `d
ilya-biryukov updated this revision to Diff 160992.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Log on index request, remove FIXME that was addressed
- Remove SymbolID::forDecl, use existing helper instead
Repository:
rCTE Clang Tools Extra
https://reviews
hokein accepted this revision.
hokein added a comment.
looks good, a few nits.
Comment at: clangd/CodeComplete.cpp:742
+llvm::DenseMap FetchedDocs;
+if (Index) {
+ LookupRequest IndexRequest;
nit: do we want to log anything here? It may be useful f
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
ilya-biryukov updated this revision to Diff 160647.
ilya-biryukov added a comment.
- run clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50727
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clangd/index/
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, kadircet.
Herald added subscribers: arphaman, mgrang, jkorous, MaskRay.
Sema can only be used for documentation in the current file, other doc
comments should be fetched from the index.
Repository:
rCTE Clang T
15 matches
Mail list logo
