ilya-biryukov added inline comments.
================
Comment at: clangd/CodeComplete.cpp:742
+ llvm::DenseMap<SymbolID, std::string> FetchedDocs;
+ if (Index) {
+ LookupRequest IndexRequest;
----------------
hokein wrote:
> nit: do we want to log anything here? It may be useful for debug.
Definitely useful. Thanks!
================
Comment at: clangd/index/Index.h:65
public:
+ static llvm::Optional<SymbolID> forDecl(const Decl &D);
+
----------------
hokein wrote:
> We already have this similar function in clangd/AST.h.
Thanks for pointing this out.
It's somewhat hard to find. WDYT about moving it to `Index.h`? The concern
would probably be a somewhat broken layering, right? E.g. `Index.h` should not
directly depend on anything AST-specific
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50727
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
