ioeric added inline comments.
================
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
----------------
ilya-biryukov wrote:
> ioeric wrote:
> > drive by: I think this should be `vlog` or `dlog`.
> Code completion also logs the number of results from sema, index, etc. using
> the `log()` call.
> The added log message looks similar, so trying to be consistent with the rest
> of the code in this file.
>
> Maybe we should turn all of them into `vlog` or `dlog`, but I'd rather leave
> it to a separate patch.
I'm not sure which level code completion log messages should be in, but I think
we should follow the guidelines in the logger documentation instead of the
existing uses.
Quote from Logger.h
```
// log() is used for information important to understanding a clangd session.
// e.g. the names of LSP messages sent are logged at this level.
// This level could be enabled in production builds to allow later inspection.
// vlog() is used for details often needed for debugging clangd sessions.
// This level would typically be enabled for clangd developers.
```
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50727
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
