[PATCH] D48628: [AST] Structural equivalence of methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336776: [AST] Structural equivalence of methods (authored by balazske, committed by ). Herald added a subscriber: llvm-com

[PATCH] D48628: [AST] Structural equivalence of methods

balazske marked an inline comment as done. balazske added inline comments. Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489 + +TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) { + auto t = makeNamedDecls( a_sidorin wrote: > balazske wrote: >

[PATCH] D48628: [AST] Structural equivalence of methods

a_sidorin added inline comments. Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489 + +TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) { + auto t = makeNamedDecls( balazske wrote: > a_sidorin wrote: > > Could you add a comment why this test is

[PATCH] D48628: [AST] Structural equivalence of methods

balazske marked an inline comment as done. balazske added inline comments. Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489 + +TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) { + auto t = makeNamedDecls( a_sidorin wrote: > Could you add a co

[PATCH] D48628: [AST] Structural equivalence of methods

balazske updated this revision to Diff 154175. balazske added a comment. - Added comment into test StructuralEquivalenceRecordTest.DISABLED_Methods. Repository: rC Clang https://reviews.llvm.org/D48628 Files: lib/AST/ASTImporter.cpp lib/AST/ASTStructuralEquivalence.cpp unittests/AST/AS

[PATCH] D48628: [AST] Structural equivalence of methods

a_sidorin accepted this revision. a_sidorin added a comment. LG with a nit. Thank you! Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489 + +TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) { + auto t = makeNamedDecls( Could you add a comment

[PATCH] D48628: [AST] Structural equivalence of methods

balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:2454 + if (IsStructuralMatch(D, FoundFunction)) { +const FunctionDecl *Definition = nullptr; +if (D->doesThisDeclarationHaveABody() && This change with `Definitio

[PATCH] D48628: [AST] Structural equivalence of methods

balazske updated this revision to Diff 154073. balazske added a comment. - Updates according to review comments Repository: rC Clang https://reviews.llvm.org/D48628 Files: lib/AST/ASTImporter.cpp lib/AST/ASTStructuralEquivalence.cpp unittests/AST/ASTImporterTest.cpp unittests/AST/Str

[PATCH] D48628: [AST] Structural equivalence of methods

balazske added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:873 + + if (auto *Constructor1 = dyn_cast(Method1)) { +if (auto *Constructor2 = dyn_cast(Method2)) { a.sidorin wrote: > ```if (Method1->getStmtKind() != Method2->getStmtKind())

[PATCH] D48628: [AST] Structural equivalence of methods

a.sidorin requested changes to this revision. a.sidorin added a comment. This revision now requires changes to proceed. Hi Balázs, I think that the test changes unrelated to C++ method equivalence should be moved into a separate patch. Comment at: lib/AST/ASTStructuralEquival

[PATCH] D48628: [AST] Structural equivalence of methods

balazske created this revision. Herald added a subscriber: cfe-commits. Added structural equivalence check for C++ methods. Improved structural equivalence tests. Added related ASTImporter tests. Repository: rC Clang https://reviews.llvm.org/D48628 Files: lib/AST/ASTStructuralEquivalence.c