a_sidorin added inline comments.
================
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+ auto t = makeNamedDecls(
----------------
balazske wrote:
> a_sidorin wrote:
> > Could you add a comment why this test is disabled?
> Methods are not checked, there was no decision about to include this check or
> not. The problem was related to performance overhead and if order-independent
> check of methods is needed. (ASTImporter should keep order of imported fields
> and methods.) (This test is about equivalence of `foo`.)
You mean that imported decl have other order of methods? Do you mean implicit
methods (because I see only a single method here)? If so, could you please note
this in the comment?
Repository:
rC Clang
https://reviews.llvm.org/D48628
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
