This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL332362: [clangd] Remove LSP command-based #include
insertion. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LG when all the dependencies are done
Comment at: unittests/clangd/ClangdTests.cpp:941
-TEST_F(ClangdVFSTest, InsertIncludes) {
- MockFSProvider FS;
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:941
-TEST_F(ClangdVFSTest, InsertIncludes) {
- MockFSProvider FS;
ilya-biryukov wrote:
> Do we test the same thing somewhere else (e.g. code co
ilya-biryukov added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:941
-TEST_F(ClangdVFSTest, InsertIncludes) {
- MockFSProvider FS;
Do we test the same thing somewhere else (e.g. code completion) in one of the
dependent changes?
Maybe it's wo
ioeric added a comment.
In https://reviews.llvm.org/D46676#1095713, @ilya-biryukov wrote:
> This LG, but we should first roll out the `additionalEdits` change.
> Aren't the dependencies reversed in the dependency stack, i.e. this change
> should be the last one?
You are right ;) I got the dep
ilya-biryukov added a comment.
This LG, but we should first roll out the `additionalEdits` change.
Aren't the dependencies reversed in the dependency stack, i.e. this change
should be the last one?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46676
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek.
clangd will populate #include insertions as addtionalEdits in completion
items.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46676
