ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LG when all the dependencies are done
================
Comment at: unittests/clangd/ClangdTests.cpp:941
-TEST_F(ClangdVFSTest, InsertIncludes) {
- MockFSProvider FS;
----------------
ioeric wrote:
> ilya-biryukov wrote:
> > Do we test the same thing somewhere else (e.g. code completion) in one of
> > the dependent changes?
> > Maybe it's worth noting in the commit description that this test was not
> > removed completely, but instead moved to <new-test-name-here>?
> Sure thing.
>
> This is tested in code completion unit tests in D46497. Noted this in patch
> summary.
Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46676
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
