ioeric marked an inline comment as done.
ioeric added inline comments.

================
Comment at: unittests/clangd/ClangdTests.cpp:941
 
-TEST_F(ClangdVFSTest, InsertIncludes) {
-  MockFSProvider FS;
----------------
ilya-biryukov wrote:
> Do we test the same thing somewhere else  (e.g. code completion) in one of 
> the dependent changes?
> Maybe it's worth noting in the commit description that this test was not 
> removed completely, but instead moved to <new-test-name-here>?
Sure thing.

This is tested in code completion unit tests in D46497. Noted this in patch 
summary.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46676



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to