This revision was automatically updated to reflect the committed changes.
Closed by commit rL331763: [clang-tidy] Profile is a per-AST (per-TU) data.
(authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46504?vs=1454
lebedev.ri added a comment.
In https://reviews.llvm.org/D46504#1091210, @alexfh wrote:
> LG with a couple of nits.
Thank you for the review, faster than ever :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46504
___
cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
std::unique_ptr OptionsProvider)
-: DiagEngine(nullptr), OptionsProvider(std::mo
lebedev.ri added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
std::unique_ptr OptionsProvider)
-: DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
- Profile(nullptr) {
+: DiagEngine(nullptr), OptionsProvider(std::m
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
std::unique_ptr OptionsProvider)
-: DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
- Profile(nullptr) {
+: DiagEngine(nullptr), OptionsProvider(st
lebedev.ri created this revision.
lebedev.ri added reviewers: alexfh, sbenza.
lebedev.ri added a project: clang-tools-extra.
Herald added subscribers: mgrang, xazax.hun, mgorny.
As discussed in https://reviews.llvm.org/D45931, currently, profiling output of
clang-tidy is somewhat not great.
It ou
