lebedev.ri added inline comments.

================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
     std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider)
-    : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
-      Profile(nullptr) {
+    : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)) {
   // Before the first translation unit we can get errors related to 
command-line
----------------
Eugene.Zelenko wrote:
> Will be good idea to use default member initialization for DiagEngine too.
Yes, but in the context of the diff that would be a completely unrelated 
change, i try to avoid those..


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46504



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to