alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider)
- : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
- Profile(nullptr) {
+ : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)) {
// Before the first translation unit we can get errors related to
command-line
----------------
lebedev.ri wrote:
> Eugene.Zelenko wrote:
> > Will be good idea to use default member initialization for DiagEngine too.
> Yes, but in the context of the diff that would be a completely unrelated
> change, i try to avoid those..
I'd better leave the initializer here for consistency with the other fields.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:168
+ /// \brief Control profile collection in clang-tidy.
+ void setCheckProfileData(bool Profile);
+ bool getCheckProfileData() const { return Profile; }
----------------
It seems to be `setEnableProfiling()` now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46504
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
