xazax.hun added a comment.
In https://reviews.llvm.org/D38844#911735, @NoQ wrote:
> Hey, i just recalled that we have documentation for `ExprInspection`
> functions in `docs/analyzer/DebugChecks.rst`, you may want to add your
> function there as well :)
Indeed, thanks for pointing this out! T
NoQ added a comment.
Hey, i just recalled that we have documentation for `ExprInspection` functions
in `docs/analyzer/DebugChecks.rst`, you may want to add your function there as
well :)
Repository:
rL LLVM
https://reviews.llvm.org/D38844
___
c
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68
// (globals should not be invalidated, etc), hence the use of evalCall.
- FnCheck Handler = llvm::StringSwitch(C.getCalleeName(CE))
-.Case("clang_analyzer_eval", &ExprIns
zaks.anna added a comment.
I'd also include some info on how it's now possible to dump the issue hash. You
introduce a new debugging function here "clang_analyzer_hashDump" but it's not
mentioned in the commit message.
Thanks!
Comment at: lib/StaticAnalyzer/Checkers/ExprInsp
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great stuff!
Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:84
&ExprInspectionChecker::analyzerNumTimesReached)
+.Case("clang_analyzer_hashDump",
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68
// (globals should not be invalidated, etc), hence the use of evalCall.
- FnCheck Handler = llvm::StringSwitch(C.getCalleeName(CE))
-.Case("clang_analyzer_eval", &ExprIns
zaks.anna added a comment.
Please, change the commit description to be more comprehensive.
Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68
// (globals should not be invalidated, etc), hence the use of evalCall.
- FnCheck Handler = llvm::StringSwitch(C.g
