This revision was automatically updated to reflect the committed changes.
Closed by commit rL303085: Make google-build-using-namespace skip
std::.*literals (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D33010?vs=99011&id=99025#toc
Repository:
rL LLVM
https://review
marejde added a comment.
> Do you need me to commit the patch for you?
Yes please. I do not have commit access.
Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48
+bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace(
+const NamespaceDecl *NS) {
-
marejde updated this revision to Diff 99011.
marejde added a comment.
Modified isStdLiteralsNamespace() to be a static method.
https://reviews.llvm.org/D33010
Files:
clang-tidy/google/UsingNamespaceDirectiveCheck.cpp
clang-tidy/google/UsingNamespaceDirectiveCheck.h
test/clang-tidy/google-
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit. Thank you for addressing this! Do you need me to commit the
patch for you?
Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48
+bool UsingNa
marejde updated this revision to Diff 98914.
marejde added a comment.
Removed use of nested namespace definition in test (C++17) and added a couple
of more namespaces with "literals" in name that check should warn for.
https://reviews.llvm.org/D33010
Files:
clang-tidy/google/UsingNamespaceDi
marejde updated this revision to Diff 98893.
marejde added a comment.
Removed use of getQualifiedNameAsString().
https://reviews.llvm.org/D33010
Files:
clang-tidy/google/UsingNamespaceDirectiveCheck.cpp
clang-tidy/google/UsingNamespaceDirectiveCheck.h
test/clang-tidy/google-namespaces.cpp
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:43
+ if (StandardLiteralsNamespaceRE.match(
+ U->getNominatedNamespace()->getQualifiedN
