marejde added a comment. > Do you need me to commit the patch for you?
Yes please. I do not have commit access. ================ Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48 +bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace( + const NamespaceDecl *NS) { ---------------- alexfh wrote: > Please make this a static free function instead, since it doesn't need access > to the check's members. Done. https://reviews.llvm.org/D33010 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits