alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with one nit. Thank you for addressing this! Do you need me to commit the 
patch for you?



================
Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48
 
+bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace(
+    const NamespaceDecl *NS) {
----------------
Please make this a static free function instead, since it doesn't need access 
to the check's members.


https://reviews.llvm.org/D33010



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to