smeenai abandoned this revision.
smeenai added a comment.
Folded into https://reviews.llvm.org/D25208
https://reviews.llvm.org/D27430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
In https://reviews.llvm.org/D27430#634882, @smeenai wrote:
> In https://reviews.llvm.org/D27430#634880, @smeenai wrote:
>
> > Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the
> > `inline _LIBCPP_INLINE_VISIBILITY` cases, at least the `inline` n
smeenai added a comment.
In https://reviews.llvm.org/D27430#634880, @smeenai wrote:
> Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the
> `inline _LIBCPP_INLINE_VISIBILITY` cases, at least the `inline` needs to be
> at the definition itself, otherwise it won't have any
smeenai added a comment.
In https://reviews.llvm.org/D27430#632652, @EricWF wrote:
> Please put these attributes to the first declaration instead of the
> definition.
Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the
`inline _LIBCPP_INLINE_VISIBILITY` cases, at least
EricWF added a comment.
Please put these attributes to the first declaration instead of the definition.
Comment at: include/thread:392
template
+_LIBCPP_HIDDEN
thread::thread(_Fp __f)
We really should hide this using `inline _LIBCPP_INLINE_VISIBILITY` becaus
smeenai requested a review of this revision.
smeenai added a comment.
I think this actually stands well on its own. I'll do the extern template
annotations in a different diff.
Also, ping :)
https://reviews.llvm.org/D27430
___
cfe-commits mailing
smeenai planned changes to this revision.
smeenai added a comment.
Hidden visibility also requires extern template declarations to expand to
default visibility (as opposed to just default type visibility) to be feasible.
Will fix annotations there and add those to this diff.
https://reviews.ll
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added subscribers: cfe-commits, thakis.
https://reviews.llvm.org/D25208 switches `_LIBCPP_TYPE_VIS` to expand to
default visibility
instead of default type visibility, in order to ease building libc++
with hidden
