EricWF added a comment.

Please put these attributes to the first declaration instead of the definition.



================
Comment at: include/thread:392
 template <class _Fp>
+_LIBCPP_HIDDEN
 thread::thread(_Fp __f)
----------------
We really should hide this using `inline _LIBCPP_INLINE_VISIBILITY` because 
it's a special C++03 symbol, so we don't even want a hidden definition omitted 
ideally.


https://reviews.llvm.org/D27430



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to