falho added a comment.
Thanks !
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r285809
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
falho added a comment.
I just figured out that I don't have right to commit to llvm so I would
appreciate if you could commit this check for me. Do you need any info about
me? Thank you!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
falho added a comment.
Thanks but I think I will try it!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D22346#581329, @falho wrote:
> Cool! Thank you for the reviews!
If you don't have commit privileges, let me know and I'm happy to commit on
your behalf.
https://reviews.llvm.org/D22346
_
falho added a comment.
Cool! Thank you for the reviews!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for working on this!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
falho updated this revision to Diff 76072.
falho marked an inline comment as done.
falho added a comment.
in cpp diagnostics message: comma changed back to semicolon, + curly braces
removed
testfiles corrected accordingly
https://reviews.llvm.org/D22346
Files:
clang-tidy/cert/CERTTidyModule.
aaron.ballman added a comment.
In https://reviews.llvm.org/D22346#580242, @falho wrote:
> removed semicolon, and replaced it with a comma that only appears in .cpp
> diagnostics
The semicolon was the correct punctuator to use, but thank you for moving it
into the cpp message.
> test cases co
falho updated this revision to Diff 75935.
falho marked an inline comment as done.
falho added a comment.
removed semicolon, and replaced it with a comma that only appears in .cpp
diagnostics
test cases corrected according to this
removed junk .swo file
https://reviews.llvm.org/D22346
Files:
aaron.ballman added a comment.
clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo was added and should not have
been; also, there's one minor issue with the diagnostic wording that is still
outstanding.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35
+ diag(MatchedDec
falho updated this revision to Diff 75460.
falho added a comment.
changes according to 2nd review
https://reviews.llvm.org/D22346
Files:
clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/LimitedRandomnessChe
aaron.ballman added a comment.
I noticed you marked several comments as done, but the patch is not updated
with changes. Have I missed something?
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
aaron.ballman added a comment.
Thank you for continuing your efforts on this, I have just a few minor nits
remaining.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35
+ diag(MatchedDecl->getLocStart(),
+ "rand() function has limited randomness; " + msg);
+}
---
falho removed rL LLVM as the repository for this revision.
falho updated this revision to Diff 74908.
falho added a comment.
Herald added subscribers: modocache, mgorny, beanz.
updated diff according to first reviews
https://reviews.llvm.org/D22346
Files:
clang-tidy/cert/.LimitedRandomnessChe
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
falho marked 5 inline comments as done.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0)))
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
xazax.hun added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
xazax.hun added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
xazax.hun added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
falho added a comment.
Hi! Thanks for the reviews! I will be off for a few days so I will start
working on it when Im back. Greetz! Benedek
Repository:
rL LLVM
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Prazek added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
Prazek added inline comments.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0
+
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Thank you for working on this check!
Comment at: clang-tidy/cert/CERTTidyModule.cpp:37
@@ -35,1 +36,3 @@
// DCL
+CheckFactories.registerCheck(
Prazek accepted this revision.
Prazek added a comment.
This revision is now accepted and ready to land.
LGTM with the fixes of docs.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:31
@@ +30,3 @@
+ Result.Nodes.getNodeAs("randomGenerator");
+ diag(MatchedDecl->getLo
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/cert-msc50-cpp.rst:4
@@ +3,3 @@
+cert-msc-50
+===
+
Should be same length as section name above.
=
30 matches
Mail list logo
