aaron.ballman added a comment.
Thank you for continuing your efforts on this, I have just a few minor nits
remaining.
================
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35
+ diag(MatchedDecl->getLocStart(),
+ "rand() function has limited randomness; " + msg);
+}
----------------
For C code, this diagnostic will read strangely due to the trailing semicolon.
You should move the semicolon into the `msg` above. Perhaps we can also drop
"function" from the diagnostic as well.
================
Comment at: docs/clang-tidy/checks/cert-msc50-cpp.rst:3
+
+cert-msc-50
+===========
----------------
This should be cert-msc50-cpp instead.
================
Comment at: docs/clang-tidy/checks/list.rst:20
cert-flp30-c
+ cert-msc50-cpp
cert-oop11-cpp (redirects to misc-move-constructor-init) <cert-oop11-cpp>
----------------
aaron.ballman wrote:
> Please also add a cert-msc30-c file with a redirect (like fio38-c from above).
This should be cert-msc30-c
https://reviews.llvm.org/D22346
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
