[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ab138c69fc: [clang][ASTImporter] Import TemplateName correctly (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D144622

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

donat.nagy accepted this revision. donat.nagy added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 ___ cfe-commits mailing list cfe-co

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

vabridgers accepted this revision. vabridgers added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 ___

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

balazske updated this revision to Diff 501539. balazske added a comment. Updated the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTI

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

donat.nagy added a comment. Basically LGTM (assuming that the TC passes), I added two minor suggestions, but I'm not opposed to merging this in its current state. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8142-8150 + R"( + template + struct A; +

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

balazske updated this revision to Diff 501161. balazske added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

balazske added a comment. I think these patches are fix for separate problems and can be applied independently. It is not better if these are moved into one change. The other patch D144273 is not finished (it can get bigger), and a test for this change is need

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

vabridgers added a comment. This patch needs a unit test (as @balazske mentioned). So far, the case we have is too large to be a suitable unittest or lit case - so requires reduction. @balazske , will you be adding this as a unittest or lit case? Also, I think this patch needs to be integrated

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs