vabridgers added a comment. This patch needs a unit test (as @balazske mentioned). So far, the case we have is too large to be a suitable unittest or lit case - so requires reduction. @balazske , will you be adding this as a unittest or lit case?
Also, I think this patch needs to be integrated with D144273 <https://reviews.llvm.org/D144273> IMHO, since they address similar issues. I verified the patch stack D144273 <https://reviews.llvm.org/D144273>, D140562 <https://reviews.llvm.org/D140562>, and D144622 <https://reviews.llvm.org/D144622> (this one) addresses the problems we've seen as a result of D133468 <https://reviews.llvm.org/D133468>. When the patches are ready, a brief history should be included in the commit header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
