[PATCH] D142316: [clang] Add test for CWG2396

2023-02-13 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51a07fc24cb9: [clang] Add test for CWG2396 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142316: [clang] Add test for CWG2396

2023-02-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142316/new/ https://reviews.llvm.org/D142316 ___

[PATCH] D142316: [clang] Add test for CWG2396

2023-02-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 496849. Endill added a comment. Remove two examples with `identity` for reasons explained in D142316#4121079 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142316/new/

[PATCH] D142316: [clang] Add test for CWG2396

2023-02-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill marked an inline comment as not done. Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::t

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-30 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } Endill wrote: >

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } shafik wrote: >

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } While gcc accep

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-26 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 492433. Endill edited the summary of this revision. Endill added a comment. Move CWG2385 out to D142315 , because it's been resolved prior to P1787 , and it's easier to explain it there. Repo

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-24 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. In D142316#4073771 , @shafik wrote: > You mention CWG2385 as na but you don't explain > how it was resolved, was it superceded by p1787 >

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-23 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. You mention CWG2385 as na but you don't explain how it was resolved, was it superceded by p1787 . Also nitpick you mentioned `P1787` in the description but it links to a ph

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-22 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also mark CWG1291 and CWG2385 as "na". P1787 : CW