This revision was automatically updated to reflect the committed changes.
Closed by commit rGfada90286008: [CUDA][HIP] Support
'--offload-arch=native' for the new driver (authored by jhuber6).
Changed prior to commit:
https://reviews.llvm.org/D141078?vs=486741&id=488237#toc
Repository:
rG LL
jhuber6 updated this revision to Diff 486741.
jhuber6 added a comment.
Change error to use canonical arch string from the triple.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141078/new/
https://reviews.llvm.org/D141078
Files:
clang/lib/Driver/
jhuber6 added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4275
+TC->getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
+<< (TC->getTriple().isNVPTX() ? "NVPTX" : "AMDGPU")
+<< llvm::toString(GPUsOrErr.takeError()) << "--
arsenm added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4275
+TC->getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
+<< (TC->getTriple().isNVPTX() ? "NVPTX" : "AMDGPU")
+<< llvm::toString(GPUsOrErr.takeError()) << "--o
arsenm added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4275
+TC->getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
+<< (TC->getTriple().isNVPTX() ? "NVPTX" : "AMDGPU")
+<< llvm::toString(GPUsOrErr.takeError()) << "--o
jhuber6 added inline comments.
Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:17
// RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpulib
--offload-arch=native --offload-new-driver
--amdgpu-arch-tool=%t/
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:17
// RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nog
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl.
Herald added subscribers: kosarev, mattd, asavonic, kerbowa, jvesely.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Her