arsenm added inline comments.

================
Comment at: clang/lib/Driver/Driver.cpp:4275
+            TC->getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
+                << (TC->getTriple().isNVPTX() ? "NVPTX" : "AMDGPU")
+                << llvm::toString(GPUsOrErr.takeError()) << "--offload-arch";
----------------
should explicitly handle the different triple cases, rather than assume ! NVPTX 
is AMDGPU


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141078/new/

https://reviews.llvm.org/D141078

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to