tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:17 // RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpulib --offload-arch=native --offload-new-driver --amdgpu-arch-tool=%t/amdgpu_arch_fail -x hip %s 2>&1 \ +// RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR ---------------- Nit: I'd reformat it a bit to make it painfully obvious that it's the combination of `--offload-arch=native` and `--amdgpu-arch-tool=%t/amdgpu_arch_fail` that makes the test hermetic. Put them on a RUN line of their own? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141078/new/ https://reviews.llvm.org/D141078 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
