[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#4013217 , @aykevl wrote: > I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't > think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is > inherently specific to that particular

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

aykevl added a comment. I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is inherently specific to that particular chip anyway so compatibility is not an issue. In fact, having two flags may even introd

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

MaskRay added a comment. > I think newr AVR projects should use clang common style options instead of > older avr-gcc style. Does GCC prefer `-mcpu=` as well? If not, raise a PR there? This seems like a decision we should not unilaterally make on llvm-project side: it's certainly something GCC

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#3974946 , @MaskRay wrote: > This makes `-mmcu=` available for non-AVR targets, which is not right. > Even for AVR, if this is a plain alias, is this really necessary? Usually > having more than one aliases for one fu

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139305/new/ https://reviews.llvm.org/D139305 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/avr-mmcu.c Index: clang/test/Driver/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480748. benshi001 retitled this revision from "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'" to "[clang][driver] Support option '-mcpu' on target AVR.". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https:/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:387 return A->getValue(); +if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) + return A->getValue(); It looks to me that -mcpu will always take prece

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 added inline comments. Comment at: clang/test/Driver/avr-mmcu.c:48 -// RUN: %clang -### --target=avr -mmcu=atmega16a -save-temps %s 2>&1 | FileCheck -check-prefix=CHECKb %s -// CHECKb: "-cc1" {{.*}} "-target-cpu" "atmega16a" -// CHECKb: "-cc1as" {{.*}} "-target-cpu" "a

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: luismarques, s.egerton, Jim, PkmX, simoncook, kristof.beyls, arichardson. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, pcwan