[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders added a comment. In D136925#3901509 , @nridge wrote: > Thanks! > > I don't think we need this much detail in the commit message; I think after > the first line it would be sufficient to say: > > Fixes https://github.com/clangd/clangd/issues/

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa68bcd81dcc9: [clangd] Index unscoped enums in class scope for code completion (authored by tom-anders). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I don't think we need this much detail in the commit message; I think after the first line it would be sufficient to say: Fixes https://github.com/clangd/clangd/issues/1082 See th

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders updated this revision to Diff 472428. tom-anders added a comment. Fix accidental line break in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136925/new/ https://reviews.llvm.org/D136925 Files: clang-tools-extra/clangd/CodeComp

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2966 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"), - cls("na::nb::Clangd4")}, + cls("na::nb::Clangd4"), enmConstant("na::C::Clangd5")}, Opts

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders updated this revision to Diff 472425. tom-anders marked 4 inline comments as done. tom-anders added a comment. Add additional test, don't bump index version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136925/new/ https://reviews.llvm.o

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2966 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"), - cls("na::nb::Clangd4")}, + cls("na::nb::Clangd4"), enmConstant("na::C::Clangd5")}, Opts); -

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:458 // data. Later we may want to support some backward compatibility. -constexpr static uint32_t Version = 17; +constexpr static uint32_t Version = 18; I don't think in