jhuber6 marked an inline comment as done.
jhuber6 added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048
CGBuilderTy &Bld = CGF.Builder;
- OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime());
+ OMPBuilder.createTargetDeinit(Bld, IsSPMD
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, two comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048
CGBuilderTy &Bld = CGF.Builder;
- OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFul
jhuber6 added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048
CGBuilderTy &Bld = CGF.Builder;
- OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime());
+ OMPBuilder.createTargetDeinit(Bld, IsSPMD, true);
}
jdoerfert wro
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048
CGBuilderTy &Bld = CGF.Builder;
- OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime());
+ OMPBuilder.createTargetDeinit(Bld, IsSPMD, true);
}
So, follow
josemonsalve2 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2565-2566
Flags<[NoArgumentUnused, HelpHidden]>;
-def fopenmp_cuda_force_full_runtime : Flag<["-"],
"fopenmp-cuda-force-full-runtime">, Group,
- Flags<[CC1Option, NoArgumentUnused, HelpHid
jdoerfert added a comment.
Remove the option and let's also remove the device flag too while we are at it.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:76
CGOpenMPRuntimeGPU::ExecutionMode &ExecMode;
bool SavedRuntimeMode = false;
Remove
=
jhuber6 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2565-2566
Flags<[NoArgumentUnused, HelpHidden]>;
-def fopenmp_cuda_force_full_runtime : Flag<["-"],
"fopenmp-cuda-force-full-runtime">, Group,
- Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
josemonsalve2 added a comment.
This is a good idea. Thanks Joseph.
Other than the two comments I made, I think this should be accepted.
Jose
Comment at: clang/include/clang/Driver/Options.td:2565-2566
Flags<[NoArgumentUnused, HelpHidden]>;
-def fopenmp_cuda_force_full_runt
