[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

MaskRay added inline comments. Herald added a subscriber: wangpc. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2442 +OperandMatchResultTy RISCVAsmParser::parseZcmpSpimm(OperandVector &Operands) { + if (getLexer().is(AsmToken::Minus)) +getLexer().Lex();

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b55e9117ebb: [RISCV] Add MC support of RISCV zcmp Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 ___

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 520253. VincentWu marked 3 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3164 } - return false; Drop this change Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:650 +LLVM_DEBUG( +

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 520170. VincentWu marked 6 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3387 + } + case RISCV::CM_POPRET: + case RISCV::CM_POPRETZ: Why is this needed? Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinte

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 520046. VincentWu added a comment. rebase & address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv-target-features.

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. The instructions need a DecoderNamespace to separate them from c.fsdsp. See D149891 for how I've done it for Zcmt. Repository: rG LL

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 519423. VincentWu marked 4 inline comments as done. VincentWu added a comment. address comments. A Decoding Conflict error of zcmt was reported when I rebase to upstream. F27326236: 8f57240fe7bfaeef5a7f2816ca1dfed.png

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM with the last 4 few comments addressed. Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:550 + if (RlistVal == RLISTENCODE::INVALID_RLIST) +

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 518662. VincentWu marked 12 inline comments as done. VincentWu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1048 + static std::unique_ptr createRlist(unsigned RlistEncode, + SMLoc S, bool IsRV64) { +auto Op = std::make_unique(KindTy::

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3150 + SMLoc Loc = Operands[1]->getStartLoc(); + return Error(Loc, "'rs1' and 'rs2' mast be different."); +} mast -> must Repository: rG LLVM Gith

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 517494. VincentWu marked 3 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1473 +ErrorLoc, +"operand must like {ra [, s0[-sN]]} or {x1 [, x8[-x9][, x18[-xN]]]}"); + } like -> be ``` "operand must be '{ra [, s0[-sN]]}' or

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 517041. VincentWu marked 18 inline comments as done. VincentWu added a comment. address comments check invalid `mvsa01 s0, s0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.or

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

kito-cheng added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2408 + +OperandMatchResultTy RISCVAsmParser::parseZcSpimm(OperandVector &Operands) { + if (getLexer().is(AsmToken::Minus)) `parseZcSpimm` -> `parseZcmpSpimm` =

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added a comment. Need to update RISCVUsage.rst Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:969 +case KindTy::Spimm: + OS << "{Spimm: "; + RISCVZC::printSpimm(Spimm.Val, OS); Why curly braces when everything else use

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 516435. VincentWu marked 2 inline comments as done. VincentWu added a comment. remove testcse of Codegen & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Fi

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

kito-cheng added inline comments. Comment at: llvm/test/CodeGen/RISCV/O0-pipeline.ll:66-67 ; CHECK-NEXT: Stack Frame Layout Analysis +; CHECK-NEXT: RISC-V Zce move merging pass +; CHECK-NEXT: RISC-V Zce Push/Pop optimization pass ; CHECK-NEXT: RISC-V p

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 516042. VincentWu marked an inline comment as done. VincentWu added a comment. address comment, remove wrong comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

asb added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:51 // CHECK-NOT: __riscv_zcf {{.*$}} +// CHECK-NOT: __riscv_zcmp // CHECK-NOT: __riscv_h {{.*$}} jrtc27 wrote: > Does this really belong in an MC patch? We typically do inclu

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

jrtc27 added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:51 // CHECK-NOT: __riscv_zcf {{.*$}} +// CHECK-NOT: __riscv_zcmp // CHECK-NOT: __riscv_h {{.*$}} Does this really belong in an MC patch? Comment at: llv

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 510661. VincentWu added a comment. rename FeatureExtZcmp -> FeatureStdExtZcmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 510467. VincentWu added a comment. Herald added subscribers: jobnoorman, jdoerfert. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Prepr

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 497206. VincentWu marked 19 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:326 +unsigned Val; +bool IsRV64; + }; Is this IsRV64 field used? Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:331 +

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 496985. VincentWu added a comment. Herald added a subscriber: luke. add doc & update to v1.0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Pre

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 463137. VincentWu added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Suppor

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 463134. VincentWu marked 9 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:116 {"zca", RISCVExtensionVersion{0, 70}}, +{"zcb", RISCVExtensionVersion{0, 70}}, +{"zcmp", RISCVExtensionVersion{0, 70}}, Why is `zcb` mixed into this patch? ==

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 459620. VincentWu added a comment. add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv-target-features

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 459617. VincentWu edited the summary of this revision. VincentWu added a reviewer: asb. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.ll

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

liaolucy added a comment. I found a lot of ZCE/zce, do we need to change ZCE to ZCMP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 ___ cfe-commits mailing li

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 456545. VincentWu marked an inline comment as done. VincentWu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. clear patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1