asb added inline comments.
================
Comment at: clang/test/Preprocessor/riscv-target-features.c:51
// CHECK-NOT: __riscv_zcf {{.*$}}
+// CHECK-NOT: __riscv_zcmp
// CHECK-NOT: __riscv_h {{.*$}}
----------------
jrtc27 wrote:
> Does this really belong in an MC patch?
We typically do include this test change in the initial MC layer patch on the
basis that the change becomes testable as soon as MC layer support is
introduced (and indeed might be used for e.g. ifdefing inline assembler, so
isn't really only useful in the presence of codegen/intrinsics support).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132819/new/
https://reviews.llvm.org/D132819
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
