jrtc27 added inline comments.
================ Comment at: clang/test/Preprocessor/riscv-target-features.c:51 // CHECK-NOT: __riscv_zcf {{.*$}} +// CHECK-NOT: __riscv_zcmp // CHECK-NOT: __riscv_h {{.*$}} ---------------- Does this really belong in an MC patch? ================ Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2307 +OperandMatchResultTy RISCVAsmParser::parseReglist(OperandVector &Operands) { + // Rlist grammar: {ra [, s0[-sN]]} (UABI) + // XRlist :{x1 [, x8[-x9][, x18[-xN]]]} (UABI) ---------------- What's UABI, a term that I've only really seen in the Linux community, got to do with assembly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits