[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42c36da9c99b: [RISCV] Add MC support of RISCV Zcb Extension (authored by VincentWu, committed by craig.topper). Repository: rG LLVM Github Monorep

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492503. craig.topper added a comment. Update file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

luismarques accepted this revision. luismarques added a comment. LGTM, with some in-line caveats. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:1 +//===-- RISCVInstrInfoZc.td - RISC-V 'Zc' instructions -*- tablegen -*-===// +// `Zc` -> `Zc*`

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492501. craig.topper added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c llv

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492494. craig.topper added a comment. Address @luismarques comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

luismarques added a comment. Possibly we want to add this change to the release notes? Comment at: llvm/lib/Target/RISCV/RISCVFeatures.td:304-308 + "'Zcb' (Shortened format for basic bit manipulation instructions)", + [FeatureExtZca

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. In D131141#4082469 , @VincentWu wrote: > should I update zcb to v1.0 in this patch? > or create a new one Let's go ahead and commit this as is. I'll add Zcb to my version bump patch D142596

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu added a comment. should I update zcb to v1.0 in this patch? or create a new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailin

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu added a comment. In D131141#4081778 , @craig.topper wrote: > @VincentWu are you ok with the changes I made? sure, thank you for your work ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/n

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492325. craig.topper added a comment. Update RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-feature

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. @VincentWu are you ok with the changes I made? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailing list cfe-co

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 492319. VincentWu added a comment. reset HEAD back to Diff 492315 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D1311

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 492318. VincentWu added a comment. rebase to upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c llv

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492315. craig.topper added a comment. Fix RUN line that was duplicate testing riscv64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preproc

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492311. craig.topper added a comment. Fix typo in RISCVBaseInfo.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-f

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492310. craig.topper added a comment. Merge uimm32_zc into uimm2. Add RISCVOp::OPERAND_TYPE_UIMM2_LSB0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: c

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492298. craig.topper added a comment. Update for rename CS_ALU to CA_ALU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-t

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492295. craig.topper added a comment. Add CSZN format as named in the spec. Reuse CLoad_ri/CStore_rri classes instead of creating new ones that were almost the same. Use CS_ALU class for c.mul. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492276. craig.topper added a comment. Add back the new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-featur

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492275. craig.topper edited the summary of this revision. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/tes

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. Herald added a subscriber: luke. Please rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailing list cfe-co

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 463187. VincentWu marked 9 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:368 +def HasStdExtZcb : Predicate<"Subtarget->hasStdExtZcb()">, + AssemblerPredicate<(all_of FeatureExtZcb), + "'Zcb' (Shortened format for basic bit

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 456542. VincentWu marked 6 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:169 + +let isCompressOnly = true in { + This feels wrong to me, but decompression is a bit dodgy if you can have all of Zcb without some of the extensions that its instructions d

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 456235. VincentWu added a comment. Herald added a subscriber: jdoerfert. Add CompressPats for zcb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/tes

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 456224. VincentWu marked 2 inline comments as done. VincentWu added a comment. set zcb inst Sched info same as their uncompressed forms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://review

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td:19 let UnsupportedFeatures = [HasStdExtZbkb, HasStdExtZbkc, HasStdExtZbkx, - HasStdExtZknd, HasStdExtZkne, HasStdExtZknh, - HasStd

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu added a comment. In D131141#3753861 , @craig.topper wrote: > Are you going to add the CompressPats in a different patch? yes, I plan submit it as CodeGen part. But I can add it into this patch if it is required. Comment at:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 456190. VincentWu marked 10 inline comments as done. VincentWu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.