[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503952. collinbaker added a comment. Missed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/In

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503950. collinbaker marked 3 inline comments as done. collinbaker edited the summary of this revision. collinbaker added a comment. Cleanups and split header order change to separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. Found some minor cleanups but otherwise LGTM (feel free to fix when landing if you'd like). Comment at: clang/tools/libclang/CXType.cpp:380-384 if (const FieldDecl *FD = dyn_cast_or_null(D)) { if

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith added inline comments. Comment at: clang/tools/libclang/CXType.cpp:13 +#include "CXType.h" #include "CIndexer.h" vedgy wrote: > collinbaker wrote: > > vedgy wrote: > > > I guess //clang-format// did this include reordering. But it certainly > > > l

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added a comment. Please update the commit message (there is no `clang_isFieldDeclBitWidthDependent` anymore) and update the revision with `arc diff --verbatim @~`. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaratio

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker marked 5 inline comments as done. collinbaker added a comment. Changed as requested. Again leaving it up to a committer to commit this Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503570. collinbaker edited the summary of this revision. collinbaker added a comment. Requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: c

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

aaron.ballman added a comment. In D130303#4176330 , @dexonsmith wrote: > In D130303#4175664 , @collinbaker > wrote: > >> @dexonsmith can you weigh in? > > Introducing `clang_isBitFieldDecl` sounds like a clean/s

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith added a comment. In D130303#4175664 , @collinbaker wrote: > @dexonsmith can you weigh in? Introducing `clang_isBitFieldDecl` sounds like a clean/straightforward solution to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker added a comment. @dexonsmith can you weigh in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ vedgy wrote: > collinbaker wrote:

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ collinbaker wrote: > vedgy wrote:

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker marked 3 inline comments as done. collinbaker added a comment. Thanks for the review. Someone else will need to commit since I don't have permission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D1

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 502763. collinbaker added a comment. Add symbol to version map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ vedgy wrote: > I just though

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 502762. collinbaker added a comment. Add release notes and remove unneeded include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNote

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 502758. collinbaker added a comment. Sync with upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/include/clang-c/Index.h clang/too

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D130303#3724392 , @dexonsmith wrote: > In D130303#3724247 , @rnk wrote: > >> Pinging alternative

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ I just thought how the new API cou

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3560 + * If a cursor that is not a bit field declaration is passed in, or if the bit + * field's width expression cannot be evaluated, -1 is returned. */ Append the following line to the com

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added subscribers: aaron.ballman, vedgy. vedgy added a comment. I just verified that this patch fixes a KDevelop crash reported by several users. Thank you! @aaron.ballman, could you please review this fix? Comment at: clan

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith added a comment. In D130303#3724247 , @rnk wrote: > Pinging alternative reviewer +@dexonsmith for a libclang API addition Looks reasonable to me -- this only changes behaviour of the existing API when there was corruption before -- but if the

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

rnk added a subscriber: dexonsmith. rnk added a comment. Pinging alternative reviewer +@dexonsmith for a libclang API addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 _

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker added a comment. Pinging this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

rnk added a comment. Dmitri, do you know a good libclang point of contact for the new API? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 ___ cfe-commits maili

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker created this revision. collinbaker added a reviewer: rnk. Herald added a subscriber: arphaman. Herald added a project: All. collinbaker requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In a class template, a bit field's width may