dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
In D130303#3724392 <https://reviews.llvm.org/D130303#3724392>, @dexonsmith 
wrote:

> In D130303#3724247 <https://reviews.llvm.org/D130303#3724247>, @rnk wrote:
>
>> Pinging alternative reviewer +@dexonsmith for a libclang API addition
>
> Looks reasonable to me -- this only changes behaviour of the existing API 
> when there was corruption before -- but if the goal is to get a vendor of 
> libclang-as-a-stable-API to sign off, I can't help.
>
> @arphaman, if you're busy, is there someone else that could take a quick look?

This still LGTM, for the same reasons. Let's just ship this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130303/new/

https://reviews.llvm.org/D130303

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to