dexonsmith added inline comments.
================ Comment at: clang/tools/libclang/CXType.cpp:13 +#include "CXType.h" #include "CIndexer.h" ---------------- vedgy wrote: > collinbaker wrote: > > vedgy wrote: > > > I guess //clang-format// did this include reordering. But it certainly > > > looks out of place and the include order becomes wrong. So I think it > > > should be reverted. > > I don't agree, it's pretty standard for a source file to have its > > associated header include at the top. > You are right, I haven't realized the header-source association. The diff is > still unrelated to the patch. But I'm no longer sure what's right, so won't > insist on anything. This is correct behaviour from clang-format. Given that there were no functional changes to includes, typically we’d omit clang-format cleanups. (I know there was a change below originally, but that was reverted.) I’m fine leaving the header clean-up in, or separating it out to different NFC commit (ideal; could be done when pushing), or skipping it entirely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
