[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added a comment. Thank you for review! Committed in https://reviews.llvm.org/rGa01579ad0a1bde4d90f4fb656f07586c3097428a. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___ cfe-commits mailin

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Looks fine to me. Thanks for fixing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___ cfe-co

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a missing comma (that can be fixed when landing). But you should give @thieta a chance to chime in before landing. Comment at: clang/www/get_started.html:72 cd build -cmake -DLLVM_ENA

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html === --- clang/ww

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

aaron.ballman added a comment. Looks pretty close, just some minor nits from me. Comment at: clang/www/get_started.html:72-75 +This builds both LLVM and Clang for release mode. Alternatively if +you need a debug build, switch Release to Debug. See +frequentl

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added inline comments. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build. cmake -DLLVM_ENABLE_PR

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435947. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html =

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

aaron.ballman added inline comments. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build. cmake -DLLVM_EN

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

thieta requested changes to this revision. thieta added a comment. This revision now requires changes to proceed. Thanks for fixing - but it's not completely accurate right now. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for deb

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta created this revision. xgupta added reviewers: thieta, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix https://github.com/llvm/llvm-project/issues/23841. Lots of beginners a