aaron.ballman added a comment.
Looks pretty close, just some minor nits from me.
================
Comment at: clang/www/get_started.html:72-75
+ <li>This builds both LLVM and Clang for release mode. Alternatively if
+ you need a debug build, switch Release to Debug. See
+ <a
href="ttps://llvm.org/docs/CMake.html#frequently-used-cmake-variables">frequently
used cmake variables</a>
+ for more options.
----------------
================
Comment at: clang/www/get_started.html:72
<li><tt>cd build</tt></li>
+ <li>This builds both LLVM and Clang for debug mode and takes a lot of time
and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a
release build.</li>
<li><tt>cmake -DLLVM_ENABLE_PROJECTS=clang -G "Unix Makefiles"
../llvm</tt></li>
----------------
xgupta wrote:
> aaron.ballman wrote:
> > thieta wrote:
> > > This isn't correct - invoking cmake without a `CMAKE_BUILD_TYPE` argument
> > > will just print an error. I would fix the command line below to include
> > > `-DCMAKE_BUILD_TYPE=Release` and have a comment saying switch Release to
> > > Debug if you need a debug build.
> > +1 to most of this, but I'd have the comment say something along the lines
> > of "See https://llvm.org/docs/CMake.html#frequently-used-cmake-variables
> > for more options".
> I hope 'most of this' also includes making changes to the default suggestion
> of -DCMAKE_BUILD_TYPE :)
> I hope 'most of this' also includes making changes to the default suggestion
> of -DCMAKE_BUILD_TYPE :)
Heh, it did! :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127496/new/
https://reviews.llvm.org/D127496
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
