[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG40c13720a4b9: [Frontend] give createInvocationFromCommandLine an options struct (authored by sammccall). Repository: rG

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

sammccall added a comment. In D124971#3493657 , @kadircet wrote: > Thanks this LGTM. Just two questions: > > - Why not migrate rest of the usages and drop the old function completely in > this patch In order to keep the patch small. I can do this as a f

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

kadircet added a comment. Thanks this LGTM. Just two questions: - Why not migrate rest of the usages and drop the old function completely in this patch - What about moving the function from clang/Frontend to Tooling, Support or FrontendTool? this is clearly only inteded to be used by tools and

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. It's accumulating