This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG41b951c92931: [RISCV] Fix int16 -> __fp16 conversion code
gen (authored by kito-cheng).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124509/new/
https://reviews.llvm.org/D124509
___
craig.topper added a comment.
I'm not opposed to this patch, but here's some additional info
I think this is failing because we hit this code in CGExprScalar.cpp. Where
SrcTy and DstTy are both i16 when using the conversion intrinsics.
// Ignore conversions like int -> uint.
if (SrcTy == Ds
khchen added a comment.
It's seem like all targets need to return `false` in
`useFP16ConversionIntrinsics` for correctness of `int16` -> `__fp16` conversion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124509/new/
https://reviews.llvm.org/D12450
kito-cheng created this revision.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,
zzheng, jrtc27, niosHD, sabuasal, si
