[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfceea4e11028: [OpenMP] Fix library path missing when using OpenMP (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 added a comment. In D122592#3411877 , @jdoerfert wrote: > In D122592#3411812 , @MaskRay wrote: > >> In D122592#3411795 , @ye-luo wrote: >> using the multiarch

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jdoerfert added a comment. In D122592#3411812 , @MaskRay wrote: > In D122592#3411795 , @ye-luo wrote: > >>> using the multiarch directory >> >> If we can cross compile libomp and libomptarget to the target system.

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418638. jhuber6 added a comment. Making suggested changes to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay added inline comments. Comment at: clang/test/OpenMP/library-path.c:1 +// RUN: %clang -### -fopenmp=libomp -v %s 2>&1 | FileCheck %s + MaskRay wrote: > Suggest the style in `linux-cross.cpp`: use `-ccc-install-dir > %S/Inputs/basic_linux_tree/usr/bin` to

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay added inline comments. Comment at: clang/test/OpenMP/library-path.c:1 +// RUN: %clang -### -fopenmp=libomp -v %s 2>&1 | FileCheck %s + Suggest the style in `linux-cross.cpp`: use `-ccc-install-dir %S/Inputs/basic_linux_tree/usr/bin` to specify InstalledD

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay added a comment. In D122592#3411795 , @ye-luo wrote: >> using the multiarch directory > > If we can cross compile libomp and libomptarget to the target system. We may > have > lib/x86_64-unknown-linux-gnu/libomp.so > lib/aarch64-unknown-linux-gnu

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418628. jhuber6 added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

ye-luo added a comment. > using the multiarch directory If we can cross compile libomp and libomptarget to the target system. We may have lib/x86_64-unknown-linux-gnu/libomp.so lib/aarch64-unknown-linux-gnu/libomp.so Compile clang once but compile runtime library for multiple architectures. Re

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 added a comment. In D122592#3411741 , @MaskRay wrote: > Another idea is to refactor `tools::addOpenMPRuntime` to use the full path of > `libomp.so` or `libomp.a` instead of `-LXXX -lomp`. > The two ways have identical semantics when `libomp.so` h

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay accepted this revision. MaskRay added a comment. Another idea is to refactor `tools::addOpenMPRuntime` to use the full path of `libomp.so` or `libomp.a` instead of `-LXXX -lomp`. The two ways have identical semantics when `libomp.so` has a `DT_SONAME` tag. In the long term, perhaps libom

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. s/include/library (commit message and code) add test. Assuming both are easy to fix, LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418617. jhuber6 added a comment. IncludePath -> LibraryPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clan

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ye-luo, MaskRay. Herald added subscribers: StephenFan, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a projec