[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. The bot that broke last time stayed green on the reland: https://lab.llvm.org/staging/#/builders/204/builds/1591 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___

[PATCH] D118070: Make lld-link work in a non-MSVC shell

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5fb05f663f2: Reland: Make lld-link work in a non-MSVC shell, add /winsysroot: (authored by pkasting, committed by thakis). Repository: rG LLVM Gi

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Relanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 409046. pkasting added a comment. Fix test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/D

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. (also marking as "request changes" for the Optional change we need) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. (reopening for fixing things + relanding) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 __

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Thanks for the revert! FWIW, also failed on https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/2069/overview / https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8822456541383185105/+/u/package_clang/stdout?format=raw . So maybe it's no

[PATCH] D118070: Make lld-link work in a non-MSVC shell

dyung added a comment. I've reverted this and the follow-up change to fix the build in 437d4e01fe4c057509dff30efd560049ad07bc99 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. It fails on this: // Validate that the default triple is used when run an empty tools dir is specified // RUN: %clang_cl -vctoolsdir "" -### -- %s 2>&1 | FileCheck %s --check-prefix VCTOOLSDIR // VCTOOLSDIR: "-triple" "{{[a-zA-Z0-9_-]*}}-pc-windows-msvc19.20.0" Wi

[PATCH] D118070: Make lld-link work in a non-MSVC shell

dyung added a comment. I'm not exactly sure why, but this change seems to be causing the Driver/cl-options.c test to fail on the PS4 Windows bot: https://lab.llvm.org/staging/#/builders/204/builds/1343 It was also failing previously after the original commit until it was reverted at which poin

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Relanded in 73e585e44d68cf77e2e3274e98c9615156a7d909 , with the new files in a new WindowsDriver library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added inline comments. Comment at: llvm/include/llvm/Support/MSVCPaths.h:15 +#include "llvm/Option/ArgList.h" +#include "llvm/Support/VirtualFileSystem.h" +#include aprantl wrote: > This introduces a cyclic dependency that breaks the `-DLLVM_ENABLE_MODULE

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Thanks for the revert! Is there any documentation for that LLVM_ENABLE_MODULES build config anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _

[PATCH] D118070: Make lld-link work in a non-MSVC shell

aprantl added a comment. Unfortunately this seems to break the modular build. Would you mind taking a look? I'm going to revert the patch to get the bots going again. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41306/console Comment at: llvm/include/llvm/Support

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. I went ahead and landed this for now. It's easy to move the 3 new files to their own library later on if we decide it's something we want to do. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new

[PATCH] D118070: Make lld-link work in a non-MSVC shell

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b2538df100: [lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot: (authored by pkasting, committed by thakis). Changed prior to comm

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added a comment. In D118070#3308304 , @pkasting wrote: > MaskRay: Friendly ping. I think I still feel that having this in LLVMSupport is strange, but am happy if the two other folks I added are happy... Repository: rG LLVM Github Monorepo C

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. MaskRay: Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406570. pkasting marked 2 inline comments as done. pkasting added a comment. Review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/too

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I think this looks great. maskray, I kind of see where you're coming from. And I'm _very_ sympathetic to keeping Support small(er). On the other hand, this is a single file that doesn't requi

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406526. pkasting added a comment. This fixes a failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt cl

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406101. Herald added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/Driver/ToolCh

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. In D118070#3297956 , @thakis wrote: > I think the setup matches what we have in clang, right? Yes, I think so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://r

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting marked an inline comment as done. pkasting added a comment. In D118070#3289222 , @ychen wrote: > Thanks for doing this! Update the release note? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. > @pkasting Note, this patch makes the outcome non-deterministic when the > auto-detection kicks in. We are stamping the command-line the .PDB file, see > https://github.com/llvm/llvm-project/blob/main/lld/COFF/PDB.cpp#L1402 - and > some live-code-patching tools rely on

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added a comment. In D118070#3290194 , @aganea wrote: > In D118070#3289227 , @MaskRay wrote: > >> I know that you want a place to be accessed by both clang driver and >> lld-link but I am a bit nervous ab

[PATCH] D118070: Make lld-link work in a non-MSVC shell

aganea added a comment. In D118070#3289227 , @MaskRay wrote: > I know that you want a place to be accessed by both clang driver and > lld-link but I am a bit nervous about the clang-driver style MSVC library > sitting inside llvm/lib/Support/. > Is the

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added subscribers: compnerd, MaskRay. MaskRay added a comment. I know that you want a place to be accessed by both clang driver and lld-link but I am a bit nervous about the MSVC library sitting inside llvm/lib/Support/. Is there a better place? @compnerd Repository: rG LLVM Github M

[PATCH] D118070: Make lld-link work in a non-MSVC shell

ychen added a comment. Thanks for doing this! Update the release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 404994. pkasting marked 5 inline comments as done. pkasting retitled this revision from "Add /winsysroot support to lld" to "Make lld-link work in a non-MSVC shell". pkasting edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES