MaskRay added a comment. In D118070#3290194 <https://reviews.llvm.org/D118070#3290194>, @aganea wrote:
> In D118070#3289227 <https://reviews.llvm.org/D118070#3289227>, @MaskRay wrote: > >> I know that you want a place to be accessed by both clang driver and >> lld-link but I am a bit nervous about the clang-driver style MSVC library >> sitting inside llvm/lib/Support/. >> Is there a better place? @compnerd @aganea > > Does it make sense to add a new platform library? LLVMPlatformWindows? > LLVMWindows? LLVMWindowsTools? LLVMWindowsABI? There is a precedent: `llvm/lib/WindowsManifest`. So having a library in `llvm/lib/` seems fine. I do not know whether it makes sense to combine the Windows driver library with `WindowsManifest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
