[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

2022-01-21 Thread Fraser Cormack via Phabricator via cfe-commits
frasercrmck added a comment. Thanks, LGTM. As a heads up, I've pinched the use of `_TU` as a suffix in D117561 . The conflicts should be minor (one location) for whichever patch is merged second. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

2022-01-21 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 401899. khchen added a comment. address frasercrmck's comments. rewrite snippet of code to fix potential bug and make more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

2022-01-20 Thread Fraser Cormack via Phabricator via cfe-commits
frasercrmck added a comment. Is "destination operand" the terminology we want? I'd have thought "passthru" was more conventional. Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1194 Operands.push_back(Node->getOperand(CurOp++)); + if (Node->getOperand(Cu

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

2022-01-19 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 401446. khchen added a comment. Address Craig's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm.org/D117647 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

2022-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1238 unsigned CurOp = 2; + bool IsTU = false; + if ((IntNo != Intrinsic::riscv_vlm && ``` bool IsTU = IntNo != Intrinsic::riscv_vlm && (!Node->getOperand

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

2022-01-19 Thread Zakk Chen via Phabricator via cfe-commits
khchen created this revision. khchen added reviewers: craig.topper, rogfer01, evandro, arcbbb, monkchiang. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruc